Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Jan 22, 2020

PR summary

HDK progress

  • globals
    • can_use_globals runs
  • call
    • shows that there is a bug in the way serialization works for results, requires weird hacking, not sure about ramifications of this
    • ideally i'd like to include a validity check on JsonString that doesn't accept invalid json so i don't have to manually audit this
  • capability
    • no tests in the hdk tests that i can see
  • commit_entry
    • can_commit_entry_macro passes
  • debug
    • debug works
  • decrypt
    • there are no tests for decrypt in hdk
  • emit_signal
    • test_signal passes
  • encrypt
    • there are no tests for encrypt in the hdk
  • entry_address
    • can_check_app_entry_address
    • can_check_sys_entry_address
  • entry_type_properties
    • test_get_entry_properties passes
  • get_entry
    • can_get_entry_ok
    • can_get_entry_bad
  • get_links
    • test_links_with_load
  • keystore
    • there are no tests for keystore in the hdk
  • link_entries
    • can_roundtrip_links
  • property
    • there are no tests for property in the hdk
  • query
    • can_check_query
  • remove_link
    • there are no tests for remove_link in the hdk
  • send
    • there are no tests for send in the hdk (there is one elided by the compiler as broken-tests)
  • sign
    • test_signing passes
  • sleep
    • smoke test seems to work, returns ok
  • update_entry
    • there are no tests in the hdk for update_entry
  • remove_entry
    • there are no tests in the hdk for remove_entry
  • show_env
    • show_env passes

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant